Skip to content

Conversation

@cryshado
Copy link
Contributor

No description provided.

@cryshado cryshado changed the title v2r1 gas opt 1537 gas -> 1511 gas v2r1 gas opt 1537 gas -> 1519 gas Aug 3, 2023
@cryshado cryshado requested a review from pyAndr3w August 3, 2023 21:40
Copy link
Contributor

@ilyar ilyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Copy link
Contributor

@ilyar ilyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to add automatic test launch via CI

Copy link
Contributor

@ilyar ilyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great before adopting this PR to add first tests for the main use cases of the contract through CI and this will reinforce the audit, and only then add a change that will clearly show that the main behavior has not changed, and the gas consumption has decreased

@cryshado cryshado marked this pull request as draft August 3, 2023 21:53
@cryshado cryshado force-pushed the gas-opt branch 2 times, most recently from a48549c to 76fa2cf Compare August 3, 2023 22:37
@cryshado cryshado marked this pull request as ready for review August 3, 2023 22:41
@nerzh
Copy link

nerzh commented Aug 4, 2023

fantastic

@pyAndr3w pyAndr3w changed the title v2r1 gas opt 1537 gas -> 1519 gas v2r2 gas opt 1537 gas -> 1519 gas Aug 6, 2023
@cryshado cryshado changed the title v2r2 gas opt 1537 gas -> 1519 gas v2r1 gas opt 1537 gas -> 1519 gas Aug 6, 2023
@cryshado cryshado changed the title v2r1 gas opt 1537 gas -> 1519 gas v2.1 gas opt 1537 gas -> 1519 gas Aug 6, 2023
@cryshado cryshado closed this Aug 6, 2023
@cryshado cryshado removed the request for review from pyAndr3w August 6, 2023 16:53
@cryshado cryshado deleted the gas-opt branch August 6, 2023 16:53
@pyAndr3w pyAndr3w restored the gas-opt branch August 7, 2023 07:24
@cryshado cryshado reopened this Aug 11, 2023
Repository owner deleted a comment from DavidGhedini Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants