-
Notifications
You must be signed in to change notification settings - Fork 15
test: run napari tests using napari workflow #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 31 31
Lines 1746 1746
=======================================
Hits 1738 1738
Misses 8 8 ☔ View full report in Codecov by Sentry. |
@Czaki ... I'm a bit confused. In the npe2 pr, you used: test_napari:
name: napari tests
uses: czaki/napari/.github/workflows/test_external_package_workflow.yml@feature/test_against_napari
is that correct? should I be switching it to |
hmmm... but then if I do that, it doesn't test against both HEAD and release of napari, which I gathered was the point. I'll wait for you to tell me what I've misunderstood :) |
Short summary. The idea is to test against the latest release and the current main. But this workflow requires updating tox configuration to allow the install dependency from the repository. So the current version tests against branch When PR is merged to |
napari/napari#6336