Return DOUBLE type for double columns in SQLAlchemy 2.0+#648
Merged
laughingman7743 merged 1 commit intomasterfrom Jan 31, 2026
Merged
Return DOUBLE type for double columns in SQLAlchemy 2.0+#648laughingman7743 merged 1 commit intomasterfrom
laughingman7743 merged 1 commit intomasterfrom
Conversation
laughingman7743
force-pushed
the
feature/double-type-sqlalchemy2
branch
4 times, most recently
from
e2ecf3b to
7976cb5
Compare
Add get_double_type() helper function that returns types.DOUBLE for SQLAlchemy 2.0+ and falls back to types.FLOAT for earlier versions. This fixes the issue where inspector.get_columns() returns FLOAT() instead of DOUBLE() for columns with 'double' data type. Changes: - Add get_double_type() helper in pyathena/sqlalchemy/types.py - Update ischema_names in pyathena/sqlalchemy/base.py - Update tests for version-compatible assertions - Add .env to .gitignore and document usage in CLAUDE.md - Fix import sorting in benchmark file Closes #647 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
laughingman7743
force-pushed
the
feature/double-type-sqlalchemy2
branch
from
7976cb5 to
b91e0f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_double_type()helper function inpyathena/sqlalchemy/types.pythat returnstypes.DOUBLEfor SQLAlchemy 2.0+ and falls back totypes.FLOATfor earlier versionsischema_namesinpyathena/sqlalchemy/base.pyto use the helper function for "double" type mappingget_double_type()for version-compatible assertions.envto.gitignoreand document.envusage for local testing inCLAUDE.mdTest plan
make chkpassestest_types.py- 29 tests passedtest_reflect_table_include_columns- passedtest_get_column_type- passedtest_numeric_type_variants- passedCloses #647