Fix retry_api_call to use getEffectiveLevel() instead of logger.level#651
Merged
laughingman7743 merged 1 commit intomasterfrom Feb 8, 2026
Merged
Fix retry_api_call to use getEffectiveLevel() instead of logger.level#651laughingman7743 merged 1 commit intomasterfrom
laughingman7743 merged 1 commit intomasterfrom
Conversation
logger.level returns 0 (NOTSET) when no level is explicitly set on the logger, even when it inherits a level from a parent logger. This causes after_log callbacks to not produce any visible output. Using getEffectiveLevel() respects the logger hierarchy and returns the correct inherited level. Closes #649 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
laughingman7743
added a commit
that referenced
this pull request
Feb 8, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry_api_callinpyathena/util.pyto uselogger.getEffectiveLevel()instead oflogger.levellogger.levelreturns0(NOTSET) when no level is explicitly set on the logger, causingafter_logretry logs to be silently droppedgetEffectiveLevel()correctly walks the logger hierarchy and returns the inherited levelCloses #649
Test plan
make chkpasses (lint, format, type check)logging.getLogger("pyathena").setLevel(logging.DEBUG)and confirm retry logs are now visible without needing to set level onpyathena.commondirectly🤖 Generated with Claude Code