Added print names for variables in equivalent circuit model#4898
Open
medha-14 wants to merge 10 commits intopybamm-team:mainfrom
Open
Added print names for variables in equivalent circuit model#4898medha-14 wants to merge 10 commits intopybamm-team:mainfrom
print names for variables in equivalent circuit model#4898medha-14 wants to merge 10 commits intopybamm-team:mainfrom
Conversation
Contributor
Author
|
Can someone please review this and let me know if this is right or if some changes need to be made :) |
agriyakhetarpal
previously approved these changes
May 4, 2025
Member
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
I missed this PR somehow. This looks good to me, thanks, @medha-14!
src/pybamm/models/submodels/equivalent_circuit_elements/rc_element.py
Outdated
Show resolved
Hide resolved
agriyakhetarpal
previously approved these changes
May 4, 2025
kratman
reviewed
May 12, 2025
src/pybamm/models/submodels/equivalent_circuit_elements/ocv_element.py
Outdated
Show resolved
Hide resolved
agriyakhetarpal
previously approved these changes
May 13, 2025
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
kratman
approved these changes
May 13, 2025
kratman
requested changes
May 13, 2025
Contributor
kratman
left a comment
kratman
left a comment
There was a problem hiding this comment.
I missed that some of the tests are failing now, can you fix that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3036
I have given latex friendly symbols to variables in the equivalent circuit model
Initially the output was:
After the latex names are given:
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests