Fix SPMe Surface Form Discrepancy#4986
Open
vidipsingh wants to merge 4 commits intopybamm-team:mainfrom
Open
Conversation
Contributor
Author
|
Hi @valentinsulzer, I've made these changes:
Is this approach correct? Any feedback would be very helpful! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4986 +/- ##
===========================================
- Coverage 99.12% 99.11% -0.01%
===========================================
Files 304 305 +1
Lines 23576 23637 +61
===========================================
+ Hits 23369 23428 +59
- Misses 207 209 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the mismatch between
surface form = "false"andalgebraicin SPMe for single-phase configs, ensuring consistent results. It also improves validation forparticle phases = ("1", "1")to avoid unintended overrides.Fixes: #4910
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests