Added OCP model to take temperature as input#5015
Open
ksudhir111 wants to merge 2 commits intopybamm-team:mainfrom
Open
Added OCP model to take temperature as input#5015ksudhir111 wants to merge 2 commits intopybamm-team:mainfrom
ksudhir111 wants to merge 2 commits intopybamm-team:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5015 +/- ##
===========================================
- Coverage 98.69% 98.46% -0.23%
===========================================
Files 303 305 +2
Lines 23256 23683 +427
===========================================
+ Hits 22953 23320 +367
- Misses 303 363 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinsulzer
requested changes
May 15, 2025
Member
valentinsulzer
left a comment
There was a problem hiding this comment.
Hey @ksudhir111 , this implementation looks good for the class itself but there are a few other steps required to make this useable within PyBaMM
- add an option to
BatteryModelOptionsfor using this open-circuit potential model, then - add a case to
lithium_ion.BaseModel.set_open_circuit_potential_submodelto use this new submodel if the "rk" option is used for open-circuit potential - add unit and integration tests
- add docs
See all the steps in https://github.com/pybamm-team/PyBaMM/pull/4816/files for guidance on where to make those changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests