feat: introduce BaseBatterySubModel and update related tests (#2221)#5254
Open
swastim01 wants to merge 4 commits intopybamm-team:mainfrom
Open
feat: introduce BaseBatterySubModel and update related tests (#2221)#5254swastim01 wants to merge 4 commits intopybamm-team:mainfrom
swastim01 wants to merge 4 commits intopybamm-team:mainfrom
Conversation
…team#2221) - Removed domain checks from BaseSubModel - Added new BaseBatterySubModel class to handle battery-specific domain validation - Updated __init__.py to include BaseBatterySubModel - Cleaned and refactored BaseSubModel tests - Added dedicated tests for BaseBatterySubModel domain validation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5254 +/- ##
========================================
Coverage 98.69% 98.69%
========================================
Files 324 325 +1
Lines 28010 28015 +5
========================================
+ Hits 27645 27650 +5
Misses 365 365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: introduce BaseBatterySubModel for battery-specific domain handling (#2221)
Description
This PR introduces the new
BaseBatterySubModelclass to handle battery-specific domain validation, moving that logic out of the genericBaseSubModel.Fixes:
Fixes #2221
Type of change
Changelog
Added under Unreleased → Features:
Important checks
nox -s pre-commitnox -s testsnox -s doctestsNotes
Tried to incorporate all the points discussed in the issue conversation, looking for feedback to make further tweaks if needed!