-
-
Notifications
You must be signed in to change notification settings - Fork 738
Add DiffSL export functionality #5370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martinjrobins
wants to merge
35
commits into
main
Choose a base branch
from
i5262-diffsl-export
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+981
−0
Open
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
7bb4d99
Don't be too strict with func_args longer than symbol.children
agriyakhetarpal 56bd16f
Add a test
agriyakhetarpal e538149
Merge branch 'develop' into roundtrip-serialisation-fix
agriyakhetarpal 425af11
Add support for uniform grid sizing across subdomains (#720) (#5253)
swastim01 d24a728
Merge branch 'develop' into roundtrip-serialisation-fix
agriyakhetarpal 6ba2cde
Fix typo in Butler-Volmer equation docstring (#5279)
cnaples79 e893156
fix bug with bulk ocp lithiation (#5280)
rtimms 6c8cbfd
doc: fix typo in concentration description in notebook (#5284)
gregordecristoforo af64ddd
Merge pull request #5276 from pybamm-team/main
valentinsulzer 385ae7b
fix: instruct uv to install into system for CI (#5288)
pipliggins 1319b4a
Fix `InputParameter` serialisation (#5289)
MarcBerliner eda4ebe
Merge branch 'develop' into roundtrip-serialisation-fix
valentinsulzer 86fec31
Merge pull request #5274 from agriyakhetarpal/roundtrip-serialisation…
valentinsulzer 80e1870
Bugfix: inputs for `initial_conditions_from` scale evaluation (#5285)
BradyPlanden 73ab559
Add `silence_sundials_errors` solver option (#5290)
BradyPlanden 593d2aa
Update C-Rate current for changing nominal capacity (#5286)
BradyPlanden df53205
Update `IDAKLUSolver` error handling (#5291)
MarcBerliner eb4874a
implement heat equation export
gregordecristoforo acd163b
Move DiffslExport to evaluate_python.py
gregordecristoforo 1bfa8ca
add tests for DiffSLExport
gregordecristoforo 8bf28e4
rename DiffslExport to DiffSLExport
gregordecristoforo 435a2a1
consider both options for heat flux output
gregordecristoforo c2502e1
move diffsl code to new file
martinjrobins b0071da
add spm, spme and dfn tests, apply fixes for these
martinjrobins 955f575
can export dfn and spme, but output is incorrect
martinjrobins 7ac5f59
new input syntax
martinjrobins 524e49a
move model export to integration, tidy up float formattting
martinjrobins aa6c6fd
merge main
martinjrobins c9b18dd
update changelog
martinjrobins 772c673
update to new delayed variable pipeline
martinjrobins 4413200
minor fixes, remove dead code
martinjrobins 7e79688
turn off pydiffsol dep for mac intel
martinjrobins 3163a60
Merge branch 'main' into i5262-diffsl-export
martinjrobins 1f9877c
don't use inplace for integration tests
martinjrobins 0ddf5e0
improve coverage
martinjrobins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.