Skip to content

Single model for experiment #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinjrobins wants to merge 34 commits into
base: main
Choose a base branch
from
+2,846 −258
Open

Single model for experiment #5422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
74497b8
feat: add unified model for experiments
martinjrobins Mar 21, 2026
fd0745e
feat: allow users to fall back to legacy model-per-step construction
martinjrobins Mar 21, 2026
0e401f1
feat: swap to using nested min instead of product for unified termina…
martinjrobins Mar 21, 2026
b7c5773
feat: impl experiment-level stop conditions for unified model
martinjrobins Mar 21, 2026
7111e20
feat: improve combined step term decoding
martinjrobins Mar 21, 2026
809c7c7
feat: support rest for padding for unified model
martinjrobins Mar 21, 2026
4731672
fix: no need for mappers for unified model
martinjrobins Mar 21, 2026
e5e19d9
test: varying temp for unified model
martinjrobins Mar 21, 2026
27066ac
test: more unified model
martinjrobins Mar 21, 2026
4c1d744
feat: resistance-control safety and test
martinjrobins Mar 21, 2026
7886f15
test: more for unified experiment model
martinjrobins Mar 21, 2026
b124266
feat: unified path does not depend on per-step storage
martinjrobins Mar 21, 2026
163671d
feat: add benchmark script for review and changelog
martinjrobins Mar 21, 2026
d554425
feat: add state mapper for unified model to set current according to …
martinjrobins Mar 22, 2026
770e95e
fix: computed variable handle missing sensitivities
martinjrobins Mar 22, 2026
d5002e1
fix: move casadi fast-with-events triggers away from experiment switches
martinjrobins Mar 22, 2026
ce684ad
coverage
martinjrobins Mar 23, 2026
af58a44
coverage2
martinjrobins Mar 23, 2026
fbe7179
coverage3
martinjrobins Mar 23, 2026
e0194fc
review comments (partial)
martinjrobins Mar 23, 2026
16ddb8d
fix: dedup setters for ambient temperature and start time
martinjrobins Mar 23, 2026
bc7b5d7
review fixes
martinjrobins Mar 23, 2026
87c7a4e
merge in main
martinjrobins Mar 23, 2026
a561ab8
coverage
martinjrobins Mar 23, 2026
846e5c1
coverage
martinjrobins Mar 24, 2026
cd8c0f5
coverage
martinjrobins Mar 24, 2026
750faf2
feat: add conditional expression node and use for unified experiment …
martinjrobins Mar 24, 2026
bc145ed
feat: benchmark does multiple solves
martinjrobins Mar 24, 2026
ecdbb65
fix: exclude step index from sensitivities
martinjrobins Mar 24, 2026
1358d13
refactor: remove mappers for unified exp model, make legacy the defau…
martinjrobins Mar 25, 2026
52e554d
Merge branch 'main' into single-model-for-experiment
martinjrobins Mar 25, 2026
b1f3a8e
update changelog
martinjrobins Mar 25, 2026
448cdad
coverage again
martinjrobins Mar 26, 2026
f31d8e7
conditional coverage
martinjrobins Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Features

- Added a unified experiment-model path that reuses a single built model and solver across compatible experiment steps. ([#5422](https://github.com/pybamm-team/PyBaMM/pull/5422))

## Bug fixes

## Breaking changes
Expand Down
2 changes: 1 addition & 1 deletion docs/source/examples/notebooks/simulations_and_experiments/simulating-long-experiments.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
" \"Hold at 4.2V until C/50\",\n",
" )\n",
" ]\n",
" * 500,\n",
" * 100,\n",
" termination=\"80% capacity\",\n",
")\n",
"sim = pybamm.Simulation(spm, experiment=experiment, parameter_values=parameter_values)\n",
Expand Down
Loading
Loading