Reduce generated project jobs to steps #119
Open
santacodes wants to merge 2 commits intopybamm-team:mainfrom
Open
Reduce generated project jobs to steps #119santacodes wants to merge 2 commits intopybamm-team:mainfrom
santacodes wants to merge 2 commits intopybamm-team:mainfrom
Conversation
Member
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @santacodes! I see that there are two annotations for the CI run at https://github.com/pybamm-team/pybamm-cookie/actions/runs/15229557825?pr=119, could you also fix them? Perhaps it's just an extraneous input?
Also, I think we can reduce this even further. On the same link, you can see that we have 16 jobs (and therefore 16 runners) for the template_test matrix, and then we have tests for all of them in 16 jobs in generated_project_tests. Your idea of keeping Python versions in separate jobs is alright – I agree there. However, running the generated project tests as a step within template_test should reduce 16 jobs from the current 36.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous CI job used
64jobs to test all the combinations of generated projects usingcopier; now the number of combinations has reduced to16. I think it would be better to keep python versions into their separate matrix as it would be much more cleaner and readable that way, personally I don't think it would be worth it to split them into their own steps with multiple python virtual environments, writing hacky scripts to generate and run tests on generated projects.Fixes #117