Tests the new entry points API in pybamm#128
Tests the new entry points API in pybamm#128medha-14 wants to merge 10 commits intopybamm-team:mainfrom
Conversation
|
I have created this pull request to test whether the entry point API is working as expected. The example notebook included here is for demonstration purposes and can be refined and added to the PyBaMM repository once approved. Please have a look and suggest any changes if needed. |
|
Thank you! I've launched the workflows. |
|
Could I get some help with the |
|
Hmm, the only source of truth for Perhaps this can help? I don't recall the context in which this was added, as it has been a while. Perhaps @santacodes does 🤔 |
I don't exactly recall this @agriyakhetarpal, as they worked out of the box when I copied and pasted these parameter values here to test the entry points. |
|
@medha-14 could you check the failing tests, I think we can merge this once you get the tests passing. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks! Please update the notebook and the source files to use PyBaMM >= 25.8, and we should be good to go. I'll delegate to @santacodes to review the notebook in detail and provide his final go-ahead.
No description provided.