fix: provide useful behavior of default py::slice
#5620
Merged
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the behavior of the default constructor of
py::slice
to be equivalent tovals[::]
. I converted a large code base from boost::python to pybind11, and one of the stumbling blocks was this issue (see #5579).Without this change, calling
a[py::slice()]
leads to an error, e.g. like this:Suggested changelog entry: