Skip to content

Conversation

@Dibyendu-IITKGP
Copy link
Contributor

@Dibyendu-IITKGP Dibyendu-IITKGP commented Nov 24, 2025

Description

Finite difference calculations of the Hessian matrix are updated in, new example notebook is added for sensitivity analysis using SALib.

Fixes # (834)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Dibyendu-IITKGP Dibyendu-IITKGP changed the title 834 sensitivity analysis create example files and update existing definitions Finite difference calculations of the Hessian matrix are updated, new example notebook is added for sensitivity analysis using SALib. Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (c11f068) to head (2d6fbc3).
⚠️ Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/analysis/classification.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #838      +/-   ##
===========================================
+ Coverage    89.81%   90.01%   +0.19%     
===========================================
  Files           61       63       +2     
  Lines         4783     4876      +93     
===========================================
+ Hits          4296     4389      +93     
  Misses         487      487              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dibyendu-IITKGP Dibyendu-IITKGP force-pushed the 834-sensitivity-analysis-create-example-files-and-update-existing-definitions branch from 235e9b0 to 97dcedf Compare November 24, 2025 14:22
@Dibyendu-IITKGP Dibyendu-IITKGP force-pushed the 834-sensitivity-analysis-create-example-files-and-update-existing-definitions branch from 280245e to 5ed34ab Compare November 25, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sensitivity analysis: create example files and update existing definitions

2 participants