fix: Omit program slot ID when not specified. #2343
Conversation
We don't have a UI for it, so we should assume no slot is chosen rather than default to the first slot. This allows the user to select the slot on the hub without a front end UI. This is compatible with the existing protocol.
|
I know this works with the current firmware, but looking forward, this might not work so well if we add additional parameters in the future. Could we change it so that instead of omitting the parameter that we have some sort of special value (e.g. |
|
That could work, although if we start adding other parameters (e.g filename or icon) it is perhaps time for a new command as part of however we might end up doing real file downloads. I think we also need to keep the case without payload for backwards compatibility with older firmware (this was the intention, but I missed it when reviewing the Pybricks Code that added this). |
No, we already have |
|
And actually, we are already reading the selected slot from the status events, so we could just put that in as the slot number and not deal with any special case for "current slot". |
|
OK. Happy to go either way. The special ID is a bit simpler but the latter might be a good exercise to start learning about redux and sagas... |
|
Closing since we will merge #2344 instead. |
We don't have a UI for it yet, so we should assume no slot is chosen rather than default to the first slot. This allows the user to select the slot on the hub without a front end UI. This is compatible with the existing protocol.