Skip to content

pbio/drv/usb_stm32: Don't stall when no app connected. #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

laurensvalk
Copy link
Member

Partially implements the timeout referenced below:

    // TODO: return PBIO_ERROR_INVALID_OP if app flag is not set. Also need a
    // timeout in case the app crashes and doesn't clear the flag on exit.

I am not merging this since @dlech is working on this, but just archiving the commit here.

It should work much better when subscribing with the app flag above. Then the timeout only affects one disconnect after normal use, rather than every time it is plugged in as in this commit.

@laurensvalk
Copy link
Member Author

I am not merging this since @dlech is working on this, but just archiving the commit here.

@coveralls
Copy link

Coverage Status

coverage: 57.109% (-0.02%) from 57.124%
when pulling 9007ef2 on usb-work
into dfbcfa8 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants