fix: include all data files in package (not just *.json) - #1
Merged
niccokunzmann merged 1 commit intoApr 19, 2026
Merged
Conversation
prepare_repository.py reads data/assistant-guidelines.md (added in v0.0.7) but the package-data glob was data/*.json, so the .md file was never included in the built wheel/sdist, causing FileNotFoundError at runtime. prompt: Write a PR for the upstream packaging bug found when adding ai-prompt-auto-commit to https://github.com/tobixen/caldav-server-tester — v0.0.7 fails with FileNotFoundError because assistant-guidelines.md is not included in the package data (only data/*.json is matched)
Member
|
Thanks! |
Member
|
Included in v0.0.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trivial bugfix ... the diff is probably more informative than the blob below:
Summary
prepare_repository.py(added in v0.0.7) readsdata/assistant-guidelines.mdviaimportlib.resources[tool.setuptools.package-data]glob wasdata/*.json, so.mdfiles were excluded from the built distributionFileNotFoundError: No such file or directory: '.../data/assistant-guidelines.md'Fix
Change the glob from
data/*.jsontodata/*so all data files are included.Reproduction
Fails with: