Fix/vtodo completed only range check - #11
Merged
Merged
Conversation
tobixen
marked this pull request as draft
May 22, 2026 09:48
tobixen
force-pushed
the
fix/vtodo-completed-only-range-check
branch
2 times, most recently
from
May 22, 2026 22:41
dfbda20 to
5b5ff47
Compare
Doing time filtering on a VTODO with a COMPLETED, but no DTSTART, DUE, or CREATED, things would crash. This was discovered a bit ad-hoc while importing some slightly broken icalendar data into a calendar, and Claude had a go on fixing it. Also, I reread RFC4791 section 9.9 and had Claude reread it again, and now I think all the corner cases are covered according to the RFC. prompt: (work on some unrelated stuff and asking Claude to investigate the crash) (I rewrote Clauds work completely) prompt: tests are broken with my last changes, but please verify if the correct thing is asserted. As I understand the relevant RFC-section, a VTODO with CREATED set but no other time-related properties should match if and only if the search interval covers the CREATED timestamp. followup-prompt: and read through section 9.9 in the caldav RFC as well. (claude concluded my new code was not in accordance with the RFC, the pre-existing assert in the test code is in accordance with the RFC, and the code section was rewritten for the second time) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tobixen
force-pushed
the
fix/vtodo-completed-only-range-check
branch
from
May 27, 2026 19:36
5b5ff47 to
b3a28e1
Compare
tobixen
marked this pull request as ready for review
May 27, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: The second commit is vibed up en-passant while trying to import some broken icalendar data into my calendar. It needs proper review and probably rebasing/rewording before it's merged.
The first commit seems to be orphaned work, maybe it needs a separate pull request, or maybe it should be dropped. I'll look into it.