Ignore invalid calendar X-WR-TIMEZONE - #37
Open
RasputinKaiser wants to merge 1 commit into
Open
Conversation
niccokunzmann
requested changes
Jun 4, 2026
niccokunzmann
left a comment
Member
There was a problem hiding this comment.
Thank you for your contributions! Would you like to co-maintain this project?
| DTEND:20260101T130000Z | ||
| SUMMARY:Invalid X-WR-TIMEZONE | ||
| END:VEVENT | ||
| END:VCALENDAR |
Member
There was a problem hiding this comment.
Thanks for this PR!
I think, we have calendar files for the tests. Please put this in there to make sure that the other tests pick them up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Summary
X-WR-TIMEZONEvalues from the input calendar as absent instead of raising during conversion.timezone=argument.Duplicate check
Invalid X-WR-TIMEZONE, andd6708488efb330c0; no matching PRs found.Tests
PATH="$PWD/.venv/bin:$PATH" .venv/bin/python -m pytest test/test_convert_examples.py test/test_copy.py test/test_command_line.py -qPATH="$PWD/.venv/bin:$PATH" .venv/bin/python -m pytest -qsh test/test_code_quality.shgit diff --checkNote: CONTRIBUTING.md asks for changelog entries except trivial changes, but I could not find a changelog/news file in this repository to update.