Rework some tests for shorter CI runs by campospinto · Pull Request #575 · pyccel/psydac

campospinto · 2026-02-13T14:26:48Z

In this PR we speed-up some tests by using coarser grids and fewer patches in multi-patch domains.

The error asserts in feec/tests/test_global_projectors.py are also improved by using the expected convergence orders.

We also add some folders in .gitignore:

prof folders generated by profiling tools
__*pyccel__*/ generated by pyccel

(Since these changes are really minor I don't think they deserve to be mentioned in the changelog)

codacy-production · 2026-02-13T15:13:49Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.01%	✅ 50.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`16fb9d3`)	31788	19587	61.62%
Head commit (`7bc8654`)	63566 (+31778)	39160 (+19573)	61.61% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#575)	2	1	50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

yguclu

Thanks for this PR! It can probably be merged very soon

yguclu · 2026-02-13T17:16:53Z

psydac/api/tests/test_2d_multipatch_mapping_maxwell.py

 def test_maxwell_2d_2_patch_dirichlet_1():

-    domain = build_pretzel()
+    # domain = build_pretzel()    # a lot of patches, takes a long time


Do we have other unit tests which actually use the pretzel-like domain?

good question! there are actually two tests left that use this domain:

"test_poisson_2d_2_patches_dirichlet_3"

"test_maxwell_2d_2_patch_dirichlet_1"

given the names of these tests, this does not make much sense. I'll fix this.

Also, I see that some tests use a domain written in 'multipatch/square.h5' but it's not clear where (and how) this domain is created. The search for 'multipatch/square.h5' or 'square.h5' or even 'multipatch/square' only return places where this domain (file) is read

psydac/api/settings.py

psydac/feec/tests/test_global_projectors.py

psydac/api/tests/test_2d_multipatch_mapping_maxwell.py

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

yguclu

Thanks for this PR, @campospinto!

I have a few minor comments

psydac/api/tests/build_domain.py

yguclu · 2026-03-02T17:11:00Z

psydac/feec/tests/test_global_projectors.py

 #==============================================================================
 if __name__ == '__main__':

    domain   = (0, 2*np.pi)
-    degree   = 3
+    degrees  = [[2,2,2], [2,3,2], [3,3,3]] #3
    periodic = True
    ncells   = [10, 20, 40, 80, 160, 320, 640]
+    mult = [[1,1,1], [1,2,2], [2,2,2]]

-    for nc in ncells:
-        test_derham_projector_2d_hdiv([nc, nc], [degree, degree], [periodic, periodic], [2, 2])
+    # for nc in ncells:
+    #     test_derham_projector_2d_hdiv([nc, nc], [degree, degree], [periodic, periodic], [2, 2])

-    for nc in ncells:
-        test_H1_projector_1d(domain, nc, degree, periodic, multiplicity = 2)
+    # for nc in ncells:
+    #     test_H1_projector_1d(domain, nc, degree, periodic, multiplicity = 2)

-    nquads = degree
-    for nc in ncells:
-        test_L2_projector_1d(domain, nc, degree, periodic, nquads)
+    # nquads = degree
+    # for nc in ncells:
+    #     test_L2_projector_1d(domain, nc, degree, periodic, nquads)

-    for nc in ncells:
-        test_derham_projector_2d_hdiv_2([nc, nc], [degree, degree], [periodic, periodic])
-        test_derham_projector_2d_hdiv([nc, nc], [degree, degree], [periodic, periodic], 2)
+    # for nc in ncells:
+    #     test_derham_projector_2d_hdiv_2([nc, nc], [degree, degree], [periodic, periodic])
+    #     test_derham_projector_2d_hdiv([nc, nc], [degree, degree], [periodic, periodic], 2)

-    for nc in ncells :
-        test_derham_projector_2d_hcurl([nc, nc], [degree, degree], [periodic, periodic])
+    # for nc in ncells :
+    #     test_derham_projector_2d_hcurl([nc, nc], [degree, degree], [periodic, periodic])

-    for nc in ncells[:3] :
-        test_derham_projector_3d([nc, nc, nc], [degree, degree, degree], [periodic, periodic, periodic])
+    for nc in ncells[:3]:
+        for deg in degrees:
+            for m in mult:
+                test_derham_projector_3d([nc, nc, nc], deg, [periodic, periodic, periodic], multiplicity=m)


Maybe we could write three separate functions in 1/2/3 dimensions and use them for this "manual" convergence verification?

I added a few functions and improved the error tests using the expected convergence orders

psydac/feec/multipatch_domain_utilities.py

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

… changes

campospinto · 2026-03-13T14:41:08Z

I think all the requests have been addressed. I'm switching on the tests again.

campospinto added 4 commits February 13, 2026 15:21

change compilation flags for M4

3cd2b73

update gitignore for profiling and temp pyccel folders

acadab7

use 2 patch for maxwell_2d_2_patch test

0ceb382

use coarser and less grids in tests

1430b70

campospinto added performance Make the code run faster testing Unit tests, coverage, benchmarks labels Feb 13, 2026

Merge branch 'devel' into shorter_CI

9c17a52

campospinto marked this pull request as draft February 13, 2026 14:30

campospinto marked this pull request as ready for review February 13, 2026 14:30

yguclu changed the title ~~rework some tests for shorter CI tests~~ Rework some tests for shorter CI runs Feb 13, 2026

Merge branch 'devel' into shorter_CI

79dc5b0

campospinto marked this pull request as draft February 18, 2026 11:45

campospinto marked this pull request as ready for review February 18, 2026 11:45

Merge branch 'devel' into shorter_CI

1fa1eb2

yguclu requested changes Feb 23, 2026

View reviewed changes

campospinto and others added 5 commits February 25, 2026 11:24

Update psydac/api/tests/test_2d_multipatch_mapping_maxwell.py

7282712

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

clean multipatch tests

830e047

update comment

2f598dd

revert changes to settings.py

88bfbde

add poisson test with bretzel domain

121ea3a

campospinto marked this pull request as draft February 26, 2026 15:02

campospinto marked this pull request as ready for review February 26, 2026 15:02

yguclu requested changes Mar 2, 2026

View reviewed changes

Require Pyccel version >= 2.2.1

4b3ed90

yguclu marked this pull request as draft March 3, 2026 07:09

yguclu marked this pull request as ready for review March 3, 2026 07:09

Update build requirement on pyccel >= 2.2.1

cafd8cd

yguclu marked this pull request as draft March 3, 2026 08:54

yguclu marked this pull request as ready for review March 3, 2026 08:54

campospinto and others added 5 commits March 3, 2026 10:29

Update psydac/api/tests/build_domain.py

2b06c44

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

Update psydac/api/tests/build_domain.py

238bab8

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

Update psydac/api/tests/build_domain.py

ff7ef79

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

Update psydac/feec/multipatch_domain_utilities.py

55003eb

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>

Require Pyccel >= 2.2.2 at build and runtime

b5b7ef9

yguclu marked this pull request as draft March 9, 2026 15:02

yguclu marked this pull request as ready for review March 9, 2026 15:02

campospinto and others added 2 commits March 9, 2026 21:53

clean build_domain.py

098ceba

Merge branch 'devel' into shorter_CI

323f8ca

yguclu marked this pull request as draft March 9, 2026 22:10

yguclu marked this pull request as ready for review March 9, 2026 22:10

Import correct domain-building functions in API unit tests after name…

ca381ff

… changes

yguclu marked this pull request as draft March 9, 2026 22:31

yguclu marked this pull request as ready for review March 9, 2026 22:31

yguclu added 2 commits March 10, 2026 08:47

Fix parentheses in connectivities of test_2d_multipatch_poisson.py

5e702c9

Clean up test_2d_multipatch_poisson.py

7bc8654

yguclu marked this pull request as draft March 10, 2026 07:55

yguclu marked this pull request as ready for review March 10, 2026 07:55

campospinto and others added 3 commits March 10, 2026 09:36

use expected conv order in projector tests

e92ba5f

Move prints from unit tests to manual run in test_global_projectors.py

73eab39

use f2 and f3 in 3D projector tests

9d4528f

campospinto marked this pull request as draft March 13, 2026 14:41

campospinto marked this pull request as ready for review March 13, 2026 14:41

accept small errors (tol = 1e-13) in convergence tests

62807d9

campospinto marked this pull request as draft March 13, 2026 16:09

campospinto marked this pull request as ready for review March 13, 2026 16:10

Conversation

campospinto commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Uh oh!

yguclu left a comment

Choose a reason for hiding this comment

Uh oh!

yguclu Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

campospinto Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yguclu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yguclu Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

campospinto Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

campospinto commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

campospinto commented Feb 13, 2026 •

edited

Loading

codacy-production bot commented Feb 13, 2026 •

edited

Loading