Skip to content

Broken FEEC projections on polar domains#576

Open
alisa-kirkinskaia wants to merge 74 commits intodevelfrom
polar_splines_alisa
Open

Broken FEEC projections on polar domains#576
alisa-kirkinskaia wants to merge 74 commits intodevelfrom
polar_splines_alisa

Conversation

@alisa-kirkinskaia
Copy link
Contributor

@alisa-kirkinskaia alisa-kirkinskaia commented Feb 18, 2026

This PR introduces broken FEEC projections for C0 and C1 sequences (conga_projections.py) in 2D.

  • Added projections C0PolarProjection_V0, C0PolarProjection_V1, C0PolarProjection_V2 onto C0 sequence, and analogously onto C1 sequence.

  • dot methods of the projections are implemented for parallel execution for arbitrary domain decompositions in the angular and/or radial dimensions.

  • Added unit tests for the projections checking:

    • the projection property P(P(x)) = P(x)
    • tosparse methods against reference matrix operators
    • consistency between dot and tosparse methods
  • Poisson and TE Maxwell 2D examples

@yguclu yguclu marked this pull request as ready for review March 9, 2026 22:13
@codacy-production
Copy link

codacy-production bot commented Mar 9, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.86% 20.90%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (16fb9d3) 31788 19587 61.62%
Head commit (4aa2591) 64954 (+33166) 39462 (+19875) 60.75% (-0.86%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#576) 689 144 20.90%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@alisa-kirkinskaia alisa-kirkinskaia marked this pull request as draft March 10, 2026 08:02
@alisa-kirkinskaia alisa-kirkinskaia marked this pull request as ready for review March 10, 2026 08:02
@alisa-kirkinskaia alisa-kirkinskaia marked this pull request as draft March 10, 2026 11:15
@alisa-kirkinskaia alisa-kirkinskaia marked this pull request as ready for review March 10, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants