Skip to content

fix: don’t forward empty JSON bodies on GET (prevents Jira 403) #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don’t forward empty JSON bodies on GET (prevents Jira 403) #2388

wants to merge 1 commit into from

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Oct 12, 2025 •
edited
Loading

  • Non-empty dict → keep existing behavior and send json.dumps(data).
  • Empty dict → remove data from prepared_kwargs so no body is sent.

While I understand this is needed I do not understand why the tests ever passed.

@traylenator traylenator requested a review from a team as a code owner October 12, 2025 09:36
@traylenator traylenator requested a review from adehad October 12, 2025 09:36
@traylenator traylenator changed the title Fix: don’t forward empty JSON bodies on GET (prevents Jira 403) fix: don’t forward empty JSON bodies on GET (prevents Jira 403) Oct 12, 2025
@traylenator
fix: don’t forward empty JSON bodies on GET (prevents Jira 403)
12bcdad 
Non-empty dict → keep existing behavior and send json.dumps(data).
Empty dict → remove data from prepared_kwargs so no body is sent.

While I understand this is needed I do not understand why the tests
ever passed.

* Fixes pycontribs#2362
@github-actions github-actions bot added the fix label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adehad adehad Awaiting requested review from adehad adehad is a code owner automatically assigned from pycontribs/jira

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_empty_dict_body_not_forwarded failure

1 participant

@traylenator