Skip to content

Conversation

guibog
Copy link

@guibog guibog commented Feb 29, 2024

No description provided.

Copy link

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

@smurfix
Copy link
Collaborator

smurfix commented Feb 29, 2024

I don't see a change that documents this new setting.

@guibog
Copy link
Author

guibog commented Feb 29, 2024

I don't see a change that documents this new setting.

Aw sorry I did not intend to send a real PR, just try some things, will switch to draft.

@guibog guibog marked this pull request as draft February 29, 2024 07:19
@guibog
Copy link
Author

guibog commented Feb 29, 2024

@smurfix I'm trying to build a command line yaml editor using jq/yq syntax, but it has to be able to edit complex yaml files in a very stable way, i.e. even better than the current round trip functionality.

For now I had two unstability issues

One with "- True" becoming "- true", this can be patched easily with add_constructor and add_representer for booleans.

Another with inconsistent indents for block sequences, for example this is a "valid" yaml:

a:
   - a1
   - a2
b:
- b1
- b2

But apparently it cannot be stabilized in a round trip call without storing the local indent somewhere, which I try in this PR, using SequenceStartEvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants