Skip to content

[feature]-fix llm review bug #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2025
Merged

[feature]-fix llm review bug #1231

merged 2 commits into from
Apr 20, 2025

Conversation

wanyewei
Copy link
Contributor

Types of changes

  • Bugfix

Description

  • 修復中英文翻譯顯示錯誤的問題
  • 讓顯示 AI summary 和 comment 的地方與 點選summary 和 comment 區塊保持間距
  • 增加當內容過多時可 scroll 的樣式設定,避免內容 overflow 無法完整閱讀

Steps to Test This Pull Request

  1. 進入審查頁面
  2. 點選其中一格稿件進入審查
  3. 右下會看到 AI 給的建議小方框
  4. 點擊小方框查看AI Summary 與 Comment 顯示區的頁面
  5. 嘗試填入大量文字,確認內容可以垂直捲動顯示
  6. 檢查中英文翻譯是否顯示正確

Expected behavior

  • 整個方框中文與英文翻譯文字應該正確對應顯示
  • AI Summary 與 Comment 內容應該能完整顯示且可捲動

Related Issue

#1218

More Information

image
image

Additional context
目前僅修正 layout 與顯示問題,後續若有 AI 回傳格式調整會再另開 PR 處理。

max-height: calc(70vh - 60px); // 根據 header 高度調整
overflow-y: auto;
-webkit-overflow-scrolling: touch;
// white-space: pre-wrap;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you keep the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因為後續可能會在調整所以先保留住,目前是先上最小可行性的版本

Copy link
Collaborator

@Ritabear Ritabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ritabear Ritabear merged commit ebd2f73 into master Apr 20, 2025
0 of 4 checks passed
@Ritabear Ritabear deleted the feat/llm-review-layout branch April 20, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants