Fix release publish package metadata#143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitestcatalog entry used bypackages/logfire-api.LICENSEcleanup frompostpacktopostpublishfor all publishable packages.Root Cause
After #142 fixed the frozen-lockfile failure, the main release job reached
changesets/actionpublish mode and failed insidepnpm run release.The first publish blocker was:
packages/logfire-api/package.jsonuses"vitest": "catalog:", butpnpm-workspace.yamlonly had avitestoverride, not a catalog entry.While verifying the fix with
pnpm publish --dry-run, pnpm 11 exposed a second publish lifecycle issue:postpackremoved the copiedLICENSEbefore pnpm finished publishing, causing anENOENTonLICENSE. Moving cleanup topostpublishkeepsLICENSEpresent through packing/publish and still cleans it afterward.Verification
pnpm publish -r --access public --dry-run --no-git-checksvp install --frozen-lockfilevp checkvp run --filter "./packages/*" build