Expose OpenTelemetry SpanKind in manual span APIs#173
Conversation
b149eff to
71152eb
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughManual span APIs now accept an optional OpenTelemetry Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/packages/logfire.md`:
- Line 1: Remove the __OPENAI_LIBRARY_FILE_READ_RECEIPT_V1__ metadata markers
from the logfire.md documentation, including the corresponding occurrence near
the end of the file, while preserving all actual documentation content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e7155ab0-4244-4228-87fe-43c4b11655d3
📒 Files selected for processing (4)
.changeset/manual-span-kind.mddocs/packages/logfire.mdpackages/logfire-api/src/index.tspackages/logfire-api/src/startPendingSpan.integration.test.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
pydantic/logfire(manual)pydantic/pydantic-ai(manual)
| @@ -1,3 +1,4 @@ | |||
| __OPENAI_LIBRARY_FILE_READ_RECEIPT_V1__={"file_name":"logfire.md","file_id":"file_000000009c3c71fbaa3b2b8dee66116c","library_file_id":"libfile_c1d2e537be808191aa0970cb6611fd6c"} | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove internal metadata from the published documentation.
These markers are not documentation content and will be rendered or retained in the source document.
Also applies to: 369-369
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/packages/logfire.md` at line 1, Remove the
__OPENAI_LIBRARY_FILE_READ_RECEIPT_V1__ metadata markers from the logfire.md
documentation, including the corresponding occurrence near the end of the file,
while preserving all actual documentation content.
|
I realized #172 was already open for this issue before this PR and now addresses the runtime log-kind edge case raised in review. I’m closing this as a duplicate to avoid splitting the review effort. Sorry I missed the overlap, and thanks for taking a look! |
Summary
SpanOptionstype with optional OpenTelemetrySpanKindkindthroughspan(),startSpan(),startPendingSpan(), andinstrument()INTERNALbehaviorlogfireminor changesetTesting
vp run logfire#test(434 tests passed)vp run logfire#typecheckvp fmt --checkvp checkFixes #171