Minor optimization: move tweaking of ASGI send/receive span level #1629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nSpanProcessorWrapper.on_start
Deploying logfire-docs with
|
| Latest commit: |
5f1d7d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c5bdc2e.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-asgi-tracer-level.logfire-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the handling of ASGI send/receive span customization by moving the logic from the span processor (which runs after span creation) to the tracer (which runs during span creation). When record_send_receive=True, spans are now created with debug log level attributes directly, rather than modifying them in post-processing.
Changes:
- Moved ASGI send/receive span log level setting from span processor to tracer creation
- Removed the
on_startoverride and helper function fromMainSpanProcessorWrapper - Extended tracer wrapper to handle both filtering and log level setting based on
record_send_receiveflag
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| logfire/_internal/integrations/asgi.py | Enhanced tracer wrapper to set debug log level at span creation time for send/receive spans when recording is enabled |
| logfire/_internal/exporters/processor_wrapper.py | Removed on_start method and _set_log_level_on_asgi_send_receive_spans function as this logic moved to tracer |
| .claude/settings.local.json | Added Claude AI configuration file for test execution permissions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #371