fix(anthropic): preserve thinking blocks in output spans#2086
Draft
chocoHacks33 wants to merge 1 commit into
Draft
fix(anthropic): preserve thinking blocks in output spans#2086chocoHacks33 wants to merge 1 commit into
chocoHacks33 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thinking/beta thinkingblocks to Logfire semconvreasoningpartsresponse_data.messagefor the default instrumentation pathWhy
Fixes the missing Anthropic thinking-block capture behind issue #1737, where extended/interleaved thinking content was not preserved cleanly in Logfire's output span data.
Validation
convert_response_to_semconv(...)andon_response(..., version=1)withThinkingBlockgit diff --checkEnvironment limits
pytest tests/otel_integrations/test_anthropic.py ...is currently blocked in this environment by an import-timePendingDeprecationWarningfrom the MCP test bootstrap (python_multipart/multipart)python -m compileall ...hit localOSError: [Errno 28] No space left on device