Copy context to new thread for sync tool calls #1576
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Apr 24, 2025
Comment on lines
35
to
38
| loop = asyncio.get_running_loop() | ||
| ctx = contextvars.copy_context() # copy the current context to the new thread | ||
| func_call = partial(func, *args, **kwargs) | ||
| return await loop.run_in_executor(None, ctx.run, func_call) |
There was a problem hiding this comment.
I think we need to run this logic with anyio, they already do this underneath.
|
We also need a test that proves it solves the issue. |
sure, added. thanks for being on top of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronous tools can be called when running an agent async - this is handled with the
run_in_executorutility function. Small but useful change for people using contextvars - pass along contextvars to the new thread.