Skip to content

Gemini Video Support #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Gemini Video Support #1584

wants to merge 2 commits into from

Conversation

kylesf
Copy link

@kylesf kylesf commented Apr 24, 2025

Summary

This pull request adds a new VideoUrl support to Gemeni and builds off MR #1435

Changes
Added support for VideoUrl to the Gemeni Models
Fix Doc Spelling Error

Type of Change
[x] Feature (new functionality)
[]Bug fix
[x] Documentation update

Checklist
[x] I have added tests
[x] I have updated the documentation
[x] I have performed a self-review of my own code

Not sure, what I may be missing. Let me know. Thanks

Copy link
Contributor

hyperlint-ai bot commented Apr 24, 2025

PR Change Summary

Added support for VideoUrl in Gemeni models and updated documentation accordingly.

  • Introduced VideoUrl support to Gemeni models
  • Corrected documentation regarding video input support
  • Updated tests to include new VideoUrl functionality

Modified Files

  • docs/input.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link
Contributor

@DouweM DouweM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good! Let's tweak the tests a bit...

)

result = await agent.run(['Explain me this video', video_url])
assert result.output.strip() == (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the snapshot helper here and up above? It should pass the assertion just the same, but will be easier to update if we ever re-run the request (skipping VCR) and the output changes slightly.

@kylesf
Copy link
Author

kylesf commented Apr 24, 2025

Think it's all set!

@kylesf kylesf closed this Apr 24, 2025
@kylesf kylesf reopened this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants