-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Make docs hooks, clai and pydantic-evals Windows compatible (use utf-8)
#3524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Viicos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth enabling the https://docs.astral.sh/ruff/rules/unspecified-encoding/ rule?
|
@Viicos hey! |
|
I updated the PR, please check Changes:
Notes:
Now they are working
|
|
It also seems that pinned Edit:
Here are the docs: https://docs.astral.sh/ruff/rules/unspecified-encoding/ IMHO, they could just check for method names, but maybe they don't want to do it |
Hey!
Summary
I'm using Windows. While I was working on #3523, I had issues with rendering docs because of
docs/.hooksI decided to change some places inside
docsandclaiandpydantic-evals, so that they useutf-8.Windows by default uses other encoding, and
utf-8needs to be specified.(At least I really don't like this behavior at all, and it will be changed in python 3.15)
Note
There're some more places where
utf-8can be specified.I noticed in some tests you actually specify
utf-8, so probably you want to minimize usage ofutf-8Then I can leave
utf-8only in.docs, if it's acceptable