-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: handle boolean JSON Schema nodes in JsonSchemaTransformer #4772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
71ab52f
373c52b
41e5f86
076daf5
6c478ed
a976000
45117c5
8071321
72d36da
ae0a50b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
devin-ai-integration[bot] marked this conversation as resolved.
Show resolved
Hide resolved
devin-ai-integration[bot] marked this conversation as resolved.
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚩 Downstream The (Refers to line 57) Was this helpful? React with 👍 or 👎 to provide feedback. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info:
items: falseskipped by falsy walrus check in_handle_array, but functionally correctAt line 154,
if items := schema.get('items'):will skipitems: falsebecauseFalseis falsy. This means_handle(False)is never called for this case. However, since_handle(False)returnsFalseimmediately (line 86-87), the end result is identical — the value is preserved as-is. This is consistent with howadditionalProperties: falseis handled in_handle_object(line 137, explicitisinstance(bool)check). The inconsistency in approach is worth noting but doesn't cause incorrect behavior.Was this helpful? React with 👍 or 👎 to provide feedback.