fix: When restoring init kwargs, use deterministic order #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @chbndrhnns for the PR. Please add test for your changes. Thanks! |
Contributor
Author
|
I added the test. However, as pointed out, we would need to set a certain hash seed BEFORE python starts. I am not sure how to integrate this in the test. With the fix now, we should never see it failing, though. |
hramezani
reviewed
Jan 2, 2026
chbndrhnns
force-pushed
the
init-deterministic
branch
from
18da31a to
93f2551
Compare
hramezani
approved these changes
Jan 2, 2026
Member
|
Thanks @chbndrhnns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #744