-
-
Notifications
You must be signed in to change notification settings - Fork 117
Add env_prefix_target #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/index.md
Outdated
| 1. `env_prefix` will be ignored and the value will be read from `FooAlias` environment variable. | ||
|
|
||
|
|
||
| If you want to apply `env_prefix` to aliases as well, set `env_prefix_target='all'` or `env_prefix_target='alias'`, which applies `env_prefix` to alias fields too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between all and alias?
docs/index.md
Outdated
| 1. `env_prefix` will be ignored and the value will be read from `FooAlias` environment variable. | ||
|
|
||
|
|
||
| If you want to apply `env_prefix` to aliases as well, set `env_prefix_target='all'` or `env_prefix_target='alias'`, which applies `env_prefix` to alias fields too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is mentioned in the docs that env_prefix does not apply to fields with alias.
please change that part of documentation
|
We have to remove the old doc because by this change |
|
Thanks @kzrnm |
Fix #748
This PR allows
env_prefixto be applied to aliases as well, without introducing any breaking changes.