Use Pydantic model_dump in serializer#761
Conversation
3aab7dd to
8670e99
Compare
|
@baumgold this is a good idea, thanks for the PR. We just need to make sure to maintain backwards compatibility. Can you add a bool kwarg ( dumped_field = dumped_model.get(field_name, model_default)You will also need to add some tests. |
|
@kschwab - I've enhanced the PR as you suggested to maintain backwards compatibility. |
6aed1be to
b63cbaf
Compare
Addresses PR feedback requesting test coverage and documentation for the use_serializers parameter added in the previous commits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Apologies for the slow follow-up on this — thanks for your patience! Here is a summary of what has been added since the initial review:
@kschwab — would you be able to take another look when you get a chance? Happy to make any further changes you suggest. |
|
thanks @baumgold for updating your PR. Could you please add a test with |
Attempts to fix #754 by using the Pydantic serializer when serializing a model via the CLI