TST: enable CPython free-threading support #468
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andfoy
changed the title
rgommers
reviewed
Mar 26, 2025
.github/workflows/ci.yml
Outdated
| - name: Install | ||
| run: | | ||
| pip install . | ||
|
|
||
| - name: Test with pytest | ||
| run: | | ||
| pip install pytest | ||
| pytest --pyargs bottleneck | ||
| pytest --parallel-threads=$PARALLEL_THREADS --pyargs bottleneck |
There was a problem hiding this comment.
This doesn't look correct, since pytest-run-parallel is only installed for cp313t. On other Python versions, this should result in:
pytest: error: unrecognized arguments: --parallel-threads=
It's annoying that CI doesn't run on this PR, but can you try running the CI job on your own fork to make sure it passes? (same for wheel builds)
|
I have approved the workflows, so now the CI will run here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables free-threading builds of bottleneck, available from Python 3.13 onwards, this new distribution allows Python packages to leverage true parallel support, as the GIL is now optional.
In particular, this PR performs the following checks:
pytest-run-parallel, which allows pytest suites to be run concurrently (per test). This analysis didn't throw any major concurrency-related issues, the only tests that were marked as thread-unsafe were related to memory usage checking and concurrent file overwriting.