Remove Python 2.x support from C code #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the module initialization code in particular more readable.
The `#define RETVAL m` was a little odd, and was hiding a bug in an error handling path - if `intern_strings` failed (doesn't happen in practice, since it'd require a very small string operation to run out of memory) then the module was still returned while on error NULL should be returned instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code quite a bit easier to read, and the second commit fixes a tiny bug in the extension module initialization code (shouldn't happen in practice, since it's the path for error handling when interning a few short strings would fail).