-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT - Workflows updates #2174
Merged
trallard
merged 4 commits into
pydata:main
from
trallard:trallard/patch-linkcheck-timeouts
Mar 25, 2025
Merged
MAINT - Workflows updates #2174
trallard
merged 4 commits into
pydata:main
from
trallard:trallard/patch-linkcheck-timeouts
Mar 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
drammock
previously approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two tiny tweaks to comments, I'll commit them as I think they are clear improvements / should be uncontroversial.
drammock
approved these changes
Mar 24, 2025
@trallard feel free to merge when CIs are green, if I don't get to it first |
Thanks @drammock 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be the last of a series of improvements to our CI:
We have been having intermittent failures on our
docs-check
workflow when trying to check links forgnu
such as:This PR tries to fix the timeout/retry issues.
Remove the RTD preview action that adds the link to the PR comment, as it has been failing despite having the correct permissions (and it seems RTD folks plan to move this to RTD directly Bring the
preview
GH action into the product readthedocs/readthedocs.org#11780)Fixes the last trigger-related issues after changing the
coverage
workflow toworkflow_call
so we get our coverage comments again (I have a PR in my repo with this working again Test PR - coverage comment trallard/pydata-sphinx-theme#2)