Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Workflows updates #2174

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Mar 24, 2025

This PR should be the last of a series of improvements to our CI:

  1. We have been having intermittent failures on our docs-check workflow when trying to check links for gnu such as:

    /home/runner/work/pydata-sphinx-theme/pydata-sphinx-theme/docs/community/topics/i18n.rst:112: WARNING: broken link: https://www.gnu.org/software/gettext/manual/gettext.html#Fuzzy-Entries (HTTPSConnectionPool(host='www.gnu.org', port=443): Max retries exceeded with url: /software/gettext/manual/gettext.html (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f6d203efb10>: Failed to establish a new connection: [Errno 101] Network is unreachable')))
    

    This PR tries to fix the timeout/retry issues.

  2. Remove the RTD preview action that adds the link to the PR comment, as it has been failing despite having the correct permissions (and it seems RTD folks plan to move this to RTD directly Bring the preview GH action into the product readthedocs/readthedocs.org#11780)

  3. Fixes the last trigger-related issues after changing the coverage workflow to workflow_call so we get our coverage comments again (I have a PR in my repo with this working again Test PR - coverage comment trallard/pydata-sphinx-theme#2)

@trallard trallard added kind: enhancement New feature or request tag: CI Pull requests that update GitHub Actions code labels Mar 24, 2025
@trallard trallard changed the title MAINT - Update linkcheck configuration MAINT - Workflows updates Mar 24, 2025
@trallard trallard marked this pull request as ready for review March 24, 2025 18:19
@drammock drammock mentioned this pull request Mar 24, 2025
drammock
drammock previously approved these changes Mar 24, 2025
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two tiny tweaks to comments, I'll commit them as I think they are clear improvements / should be uncontroversial.

@drammock
Copy link
Collaborator

@trallard feel free to merge when CIs are green, if I don't get to it first

@trallard
Copy link
Collaborator Author

Thanks @drammock 🙏🏽

@trallard trallard merged commit e2ac35d into pydata:main Mar 25, 2025
31 checks passed
@trallard trallard deleted the trallard/patch-linkcheck-timeouts branch March 25, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants