Fix three separate test failures (a11y, Sphinx dev, Sphinx 7.3)

[gabalafou]

Fixes #2199.

This should also:

• fix the a11y-tests CI check which is currently failing on all new PRs
• fix a warning that occurs whenever Sphinx >= 7.3 is used
• fix a warning that occurs when the latest/dev version of Sphinx is used

How to test

Run a contrast checker on the following preview build pages.

Check each page both in light mode and dark mode:

1. Read the Docs - PR 2204 - Kitchen Sink - Tables - specifically check "list tables"
2. Read the Docs - PR 2204 - Kitchen Sink - Admonitions - specifically check the following five admonitions: topic, version added, version changed, deprecated and version removed

Screenshots

The following two screenshots, one for light mode and one for dark mode, show the topic admonition (with higher contrast link) above a regular admonition to show the difference between the regular contrast link color versus the higher contrast link color.

The following two screenshots, one for light mode and one for dark mode, show the four different version-related admonitions, which use higher contrast links, below a warning admonition, which uses regular contrast.

Note that in the version changed admonition (dark mode), the link color is even higher contrast (teal-300) than the other higher contrast links (teal-400).

The following two screenshots show the same table in light and dark mode (all of the links use the higher contrast color).

[gabalafou]

I think all of the test failures are unrelated to this PR except maybe one, docs-checks / build PST docs (ubuntu-latest, 3.9, 6.1) (pull_request), which contains the following in the log output:

kitchen-sink/admonitions.rst:161: ERROR: Unknown directive type "versionremoved".

.. versionremoved:: v0.1.1

   Here's a version removed message.

   We also support *italic*, **bold**, ``code``, `links <https://www.sphinx-doc.org/en/master/>`_, and more.

I'm not sure why versionremoved produces an "unknown directive type" error.

[stevepiercy]

@gabalafou the test says Running Sphinx v6.1.3 https://github.com/pydata/pydata-sphinx-theme/actions/runs/14901673681/job/41854784941?pr=2204#step:4:36. versionremoved was added in Sphinx 7.3.0 https://www.sphinx-doc.org/en/master/changes/7.3.html#release-7-3-0-released-apr-16-2024.

See also:

• Add support for versionremoved directive #2087
• update kitchen sink pages #2190

[gabalafou]

I have labeled this PR as high impact for two reasons:

1. Every PR created until this gets merged will have a failing CI check for accessibility
2. We say that our goal is to conform with WCAG 2.1 Level AA

[trallard]

I think all of the test failures are unrelated to this PR except maybe one, docs-checks / build PST docs (ubuntu-latest, 3.9, 6.1) (pull_request), which contains the following in the log output:

Do you mean all a11y-tests related failures? I am not sure, but since we have had the failures on our CI for a while it has been hard to track new failures.
Could you do a quick check on other runs of the workflow just to rule out this being introduced here?

[gabalafou]

I'm re-running the workflows and checking

[trallard]

Nice, thanks @gabalafou
Seems now we only have the actual link_check failure (gettext has been a problem from the beginning, so I might skip them altogether).

And the new lighthouse one (ref GoogleChrome/lighthouse#16404) that we can address separately

[trallard]

Thanks @gabalafou this looks good to me, just left one comment that is not a merge-blocker, so will leave it to you to decide if you will leave as is or change.

[gabalafou]

And the new lighthouse one (ref GoogleChrome/lighthouse#16404) that we can address separately

I think the Lighthouse failures are the result of a combination of two factors. One factor is that our Lighthouse test site is not loading and applying our CSS to the test pages. I think that's probably been true for some time. And then more recently a new check was added to Lighthouse, which you referenced.

[trallard]

Interesting that this was working without any globbing before.
Good catch tho.