feat: add dismiss button to announcement banner#2287
Merged
Carreau merged 1 commit intopydata:mainfrom Feb 18, 2026
Merged
Conversation
Member
Author
|
This seems to work on the readthedocs preview as well: https://pydata-sphinx-theme--2287.org.readthedocs.build/en/2287/index.html I am only not sure why the alignment of the close button seems to be different (left vs right) for the announcement vs version warning banner, as I don't see any difference in css |
Collaborator
|
Dismissing for 14 days is already a great step forward. I will try to review/merge that before end of month, but no promises. |
4b358dd to
20f733f
Compare
Collaborator
|
Ok, the month has been long; merging. |
Carreau
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1384
Using essentially the same approach as was used for the version warning banner in #1763
Some questions for the announcement banner compared to the versions:
Note: I only tested it with a remote announcement that gets injected, not yet with a local snippet.