Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Array API failures. #836

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Jan 27, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

  • Fix Array API tests for Numba backend.
  • Fix Array API tests for Finch backend.

@hameerabbasi hameerabbasi changed the title Fix Array API failures. fix: Fix Array API failures. Jan 27, 2025
@github-actions github-actions bot added the fix label Jan 27, 2025
@hameerabbasi hameerabbasi requested a review from mtsokol January 27, 2025 08:30
@hameerabbasi hameerabbasi enabled auto-merge (rebase) January 27, 2025 08:51
@hameerabbasi hameerabbasi merged commit 4f81989 into pydata:main Jan 27, 2025
25 of 26 checks passed
@mtsokol mtsokol deleted the fix-array-api branch January 27, 2025 09:00
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #836 will degrade performances by 12.19%

Comparing hameerabbasi:fix-array-api (2dfd5b6) with main (2bca00c)

Summary

⚑ 6 improvements
❌ 1 regressions
βœ… 333 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚑ test_index_fancy[side=100-rank=1-format='coo'] 1,405.8 ¡s 936.3 ¡s +50.15%
⚑ test_index_fancy[side=100-rank=3-format='coo'] 3.5 ms 2.9 ms +18.73%
⚑ test_index_fancy[side=1000-rank=2-format='coo'] 4.5 ms 3.9 ms +16.1%
❌ test_index_slice[side=100-rank=2-format='gcxs'] 2.3 ms 2.6 ms -12.19%
⚑ test_index_slice[side=1000-rank=2-format='coo'] 1.6 ms 1.4 ms +13.09%
⚑ test_elemwise[f=<built-in function add>-backend='Numba'-side=1000] 5.3 ms 4.6 ms +14.88%
⚑ test_elemwise[f=<built-in function add>-backend='Numba'-side=100] 3.5 ms 3.1 ms +13.2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants