-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid datatree to zarr append dim #10156
Merged
TomNicholas
merged 16 commits into
pydata:main
from
TomNicholas:forbid_datatree_to_zarr_append_dim
Mar 20, 2025
Merged
Forbid datatree to zarr append dim #10156
TomNicholas
merged 16 commits into
pydata:main
from
TomNicholas:forbid_datatree_to_zarr_append_dim
Mar 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dcherian
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call.
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Mar 25, 2025
* upstream/main: Move chunks-related functions to a new file (pydata#10172) Preserve label ordering for multi-variable GroupBy (pydata#10151) Update DataArray.to_zarr to match Dataset.to_zarr. (pydata#10164) Fix numpy advanced indexing docs link (pydata#10160) Forbid datatree to zarr append dim (pydata#10156) Fix GitHub Actions badge in README (pydata#10155) Add dev whats-new (pydata#10152) Release 2025.03.0 (pydata#10143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
plan to merge
Final call for comments
topic-DataTree
Related to the implementation of a DataTree class
topic-zarr
Related to zarr storage library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this didn't break a single test, meaning that we are not currently testing
DataTree.to_zarr(append_dim=...)
at all. This is meant as a stopgap to avoid undefined behaviour until #9858 is resolvedCloses #xxxxTests addedwhats-new.rst
New functions/methods are listed inapi.rst