Skip to content

Conversation

@scaramallion
Copy link
Member

@scaramallion scaramallion commented Jul 30, 2025

I can see myself on my deathbed, still trying to get this working properly.

The dropdown buttons use an equivalency match for 'version' value in switcher.JSON to the version_match attr in the conf.py file, BUT the warning banner uses a different method for matching based on compare-versions, so one can match and the other not. I think the solution is to use MAJOR.MINOR.* (or MAJOR.MINOR.PATCH) in both switcher.json and conf.py, but we'll see.

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b75a3f4) to head (eb193c6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1042   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         9013      9013           
=========================================
  Hits          9013      9013           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scaramallion scaramallion merged commit 08b82b7 into pydicom:main Jul 30, 2025
13 checks passed
@scaramallion scaramallion deleted the doc-switcher-4 branch July 30, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant