Use wildcard to fix warning banner #1042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see myself on my deathbed, still trying to get this working properly.
The dropdown buttons use an equivalency match for 'version' value in switcher.JSON to the
version_matchattr in the conf.py file, BUT the warning banner uses a different method for matching based on compare-versions, so one can match and the other not. I think the solution is to use MAJOR.MINOR.* (or MAJOR.MINOR.PATCH) in both switcher.json and conf.py, but we'll see.Tasks