Enforce more ruff rules#1065
Merged
Merged
Conversation
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
b10e3b7 to
cbb15d6
Compare
Unnecessary list comprehension (rewrite as a set comprehension)
Unnecessary `tuple()` call (rewrite as a literal)
Unnecessary `list()` call within `sorted()`
Unnecessary list comprehension (rewrite using `list()`)
Unnecessary list comprehension
Implicitly concatenated string literals on one line
Prefer `object` to `Any` for the second parameter to `__eq__` Prefer `object` to `Any` for the second parameter to `__ne__`
Return the condition directly
Use `key in dict` instead of `key in dict.keys()`
Yoda condition detected
Extracting value from dictionary without calling `.items()`
Use `type` instead of `Type` for type annotation
Use f-string instead of `format` call
Avoid extraneous parentheses
Import from `collections.abc` instead
Use `X | None` for type annotations
Use `s.extend(...)` instead of repeatedly calling `s.append()` Manual changes applied instead.
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
cbb15d6 to
b6c69ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 28 28
Lines 9012 8984 -28
==========================================
- Hits 9001 8973 -28
Misses 11 11
🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks