Skip to content

Enforce ruff/pygrep-hooks rules (PGH)#1079

Draft
DimitriPapadopoulos wants to merge 3 commits into
pydicom:mainfrom
DimitriPapadopoulos:PGH
Draft

Enforce ruff/pygrep-hooks rules (PGH)#1079
DimitriPapadopoulos wants to merge 3 commits into
pydicom:mainfrom
DimitriPapadopoulos:PGH

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Mar 8, 2026

Reference issue

Enforce ruff/pygrep-hooks rules (PGH).

Relies on #1077.

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

Use specific rule codes when ignoring type issues
Use specific rule codes when using `noqa`
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.72%. Comparing base (a9b9312) to head (6e3ee98).

Files with missing lines Patch % Lines
pynetdicom/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
- Coverage   99.87%   99.72%   -0.16%     
==========================================
  Files          28       28              
  Lines        8984     8984              
==========================================
- Hits         8973     8959      -14     
- Misses         11       25      +14     
Files with missing lines Coverage Δ
pynetdicom/ae.py 100.00% <100.00%> (ø)
pynetdicom/association.py 100.00% <100.00%> (ø)
pynetdicom/dimse.py 100.00% <100.00%> (ø)
pynetdicom/dimse_messages.py 100.00% <ø> (ø)
pynetdicom/dsutils.py 100.00% <100.00%> (ø)
pynetdicom/events.py 100.00% <100.00%> (ø)
pynetdicom/pdu.py 100.00% <100.00%> (ø)
pynetdicom/pdu_items.py 100.00% <100.00%> (ø)
pynetdicom/presentation.py 100.00% <100.00%> (ø)
pynetdicom/service_class.py 100.00% <ø> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant