Run ruff on tests#1080
Draft
DimitriPapadopoulos wants to merge 24 commits into
Draft
Conversation
Pointless comparison at end of function scope. Did you mean to return the expression result?
Found useless expression. Either assign it to a variable or remove it.
`zip()` without an explicit `strict=` parameter
Unnecessary list comprehension (rewrite as a set comprehension)
Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
Implicitly concatenated string literals on one line
Explicitly concatenated string should be implicitly concatenated
Use `typing.NamedTuple` instead of `collections.namedtuple`
Comparison to `None` should be `cond is None`
Avoid equality comparisons to `True`; use `item.response_requested:` for truth checks
Test for membership should be `not in`
Do not use bare `except`
Ambiguous variable name: `l`
Imported but unused
`from ... import *` used; unable to detect undefined names
Name may be undefined, or defined from star imports
f-string without any placeholders
Redefinition of unused name
Undefined name
Local variable is assigned to but never used
Use f-string instead of `format` call
Version block is outdated for minimum Python version
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Do not exclude tests form linter checks. It finds actual errors in tests.
Tasks