Skip to content

RAP Definition based on energy ratio#114

Merged
mberz merged 12 commits intodevelopfrom
feature/definition_from_energy_ratio
Mar 3, 2026
Merged

RAP Definition based on energy ratio#114
mberz merged 12 commits intodevelopfrom
feature/definition_from_energy_ratio

Conversation

@sbch22
Copy link
Copy Markdown
Contributor

@sbch22 sbch22 commented Jan 7, 2026

Which issue(s) are closed by this pull request?

Closes #80

Changes proposed in this pull request:

@sbch22 sbch22 force-pushed the feature/definition_from_energy_ratio branch from f4dff4b to d6c481e Compare February 28, 2026 13:06
@sbch22 sbch22 moved this from Implementation in progress to Require review in Weekly Planning Feb 28, 2026
Copy link
Copy Markdown
Contributor

@artur-pa artur-pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Member

@f-brinkmann f-brinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a wrong indention, otherwise approved

@github-project-automation github-project-automation bot moved this from Require review to Reviewer Approved in Weekly Planning Mar 1, 2026
Copy link
Copy Markdown
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small docstring comments.

@github-project-automation github-project-automation bot moved this from Reviewer Approved to Require review in Weekly Planning Mar 2, 2026
@github-project-automation github-project-automation bot moved this from Require review to Reviewer Approved in Weekly Planning Mar 3, 2026
@mberz mberz merged commit 2754e9f into develop Mar 3, 2026
13 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Weekly Planning Mar 3, 2026
@mberz mberz deleted the feature/definition_from_energy_ratio branch March 3, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request v1.0.0

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants