Open
Conversation
h-chmeruk
added a commit
that referenced
this pull request
Mar 20, 2026
…ggestion in the PR #154 by @f-brinkmann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Hi @h-chmeruk this is a suggestion to improve the if case that you commented on in
intersection_time_lundeby.This suggestion fails for the case
cdim==2below, which probably requires broadcasting in_smooth_rir. Maybe this can be fixed and the if case be avoided in a similar way, i.e., by broadcasting the parameter that now can be an array like as well