MAINT: Remove the air attenuation function#157
Merged
Conversation
mberz
added
the
maintenance
mberz
requested review from
a team,
SimonBuechner,
ahms5,
artur-pa,
f-brinkmann and
hoyer-a
f-brinkmann
requested changes
Mar 18, 2026
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Removing is fine, but ruff points at a remaining use in parametric.py. Can you please fix that as well?
Member
Author
whoopsie, thanks! |
Member
Author
|
Indeed, this PR requites #74 to be merged first. |
Has been moved to pyfar since version 0.8.0
mberz
force-pushed
the
maint/remove_air_attenuation
branch
from
a1d0089 to
847ca59
Compare
Member
Author
Should be fixed now. |
f-brinkmann
approved these changes
Mar 18, 2026
github-project-automation
bot
moved this from Require review
to Done
in Weekly Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: