Conversation
f-brinkmann
added
the
maintenance
f-brinkmann
force-pushed
the
maint/history_for_1.0
branch
from
1bf33d8 to
8476f47
Compare
f-brinkmann
requested review from
a team,
SimonBuechner,
ahms5,
artur-pa,
hoyer-a and
mberz
hoyer-a
reviewed
Mar 19, 2026
Member
There was a problem hiding this comment.
I think those are missing:
- #159: remove support for python < 3.11
Some pulls from ASSA 2025 went into develop without milestone:
Member
Author
f-brinkmann
force-pushed
the
maint/history_for_1.0
branch
from
6d34ec1 to
f607d2e
Compare
hoyer-a
requested changes
Mar 19, 2026
HISTORY.rst
Outdated
Comment on lines
+22
to
+23
| - ``pyrato.parametric`` containing functions to compute room acoustical parameters from room impulse responses. | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| - ``pyrato.parametric`` containing functions to compute room acoustical parameters from room impulse responses. | |
| - ``pyrato.parametric`` containing functions to compute room acoustical parameters from simple geometric considerations. | |
| - ``pyrato.parameters`` containing functions to compute room acoustical parameters from room impulse responses. |
Isn't it the other way round?
hoyer-a
requested changes
Mar 19, 2026
HISTORY.rst
Outdated
| - ``clarity`` to compute the clarity for arbitrary time limits including the standardized parameters C50 and C80. | ||
| - ``early_lateral_energy_fraction`` to compute the ear lateral energy fraction J_LF. | ||
| - ``late_lateral_sound_level`` to compute the late lateral sound level L_J | ||
| - ``sound_strength`` to compute the sound sound_strength G. |
Member
There was a problem hiding this comment.
Suggested change
| - ``sound_strength`` to compute the sound sound_strength G. | |
| - ``sound_strength`` to compute the sound strength G. |
HISTORY.rst
Outdated
| - Room acoustic parameters according to ISO 3382 to ``pyrator.parameters`` | ||
|
|
||
| - ``clarity`` to compute the clarity for arbitrary time limits including the standardized parameters C50 and C80. | ||
| - ``early_lateral_energy_fraction`` to compute the ear lateral energy fraction J_LF. |
Member
There was a problem hiding this comment.
Suggested change
| - ``early_lateral_energy_fraction`` to compute the ear lateral energy fraction J_LF. | |
| - ``early_lateral_energy_fraction`` to compute the early lateral energy fraction J_LF. |
mberz
force-pushed
the
maint/history_for_1.0
branch
from
0610ef0 to
4ab1d99
Compare
github-project-automation
bot
moved this from Require review
to Done
in Weekly Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Draft History for pyrato v1.0.0
Marco and I will release later today.